Sculk

Made Sculk Shrieker model, textures, and sounds more accurate (thank you, Merp!) Various crash fixes.

Additions:

Added gamerules upwardSpread and downwardSpread, allowing you to control how far up and down Sculk can spread!

Changes:

Gamerule spreadMultiplier can now be set as high as 20.

Implemented a few performance improvements into non-threaded Sculk Growths, so they should be slightly less laggy if you turn the gamerule off.

The Sculk block's texture is now randomly rotated like grass and stone to match Sculk as shown off in Minecraft Live.

The mod's in-game icon has been updated with a render using the Isometric Renders mod, check it out here: https://github.com/glisco03/isometric-renders

Literally just fixes a bug with Catalysts where they wouldn't have an animation/particles while sculkThreading was enabled - which is pretty much always.

What caused this bug?

I decided to essentially rework half of the multithreading code I'd written, and I eventually stopped Catalysts from creating the threads, and moved that functionality onto entities if they die withing an 8-block radius of Catalysts. This has no noticeable impact to the player, but for me, it was amazing. I finally didn't have to worry about random crashes and log spam from multiple Catalysts coincidentally trying to place veins/sculk on the same block, and the Sensor/Shrieker growth code could FINALLY work properly without having to guess when the Sculk would be placed. How it was implemented previously, it was entirely possible for no Sensors or Shriekers to grow if you have quite a low-end device. I used the .join(); method to tie the Sensor/Shrieker growth code in with the Sculk Growth code and to run it ONLY after all the Sculk had grown so it would work properly.

So, what caused the bug? Oh, yeah. While making the entities themselves call for the threads to run, I forgot to make them emit the Death GameEvent I added. I literally just had to copy and paste one line and I fixed the bug

Changes:

Stopped Sculk Sensor/Activator placement from loading unloaded chunks and causing HUGE lag spikes.

Improved multithreading for Sculk Sensor/Shrieker placement to now wait for Sculk to be placed in order for the correct amount to grow.

Sculk Sensors and Shriekers will now wait an entire tick before being able to activate once grown through a Catalyst. This should prevent situations where players instantly get the Darkness effect when a mob dies.

Sculk Vein placement should now perform better and not cause lag.

Removed the "divideCatalysts" gamerule, as it is now the default and greatly improves performance.

Multiple small optimizations have been made to help slightly boost performance with this mod in general.

Bug Fixes:

HUGE: Sculk Growths will no longer cause lag once you leave the spawn chunks of a server/world.

The number of threads being used will no longer double or reduce the amount of Sculk placed.

Fixed many bugs where Sculk Veins would cause log spam due to trying to change the BlockState of air.

Changes:

Stopped Sculk Sensor/Activator placement from loading unloaded chunks and causing HUGE lag spikes.

Improved multithreading for Sculk Sensor/Shrieker placement to now wait for Sculk to be placed in order for the correct amount to grow.

Sculk Sensors and Shriekers will now wait an entire tick before being able to activate once grown through a Catalyst. This should prevent situations where players instantly get the Darkness effect when a mob dies.

Sculk Vein placement should now perform better and not cause lag.

Removed the "divideCatalysts" gamerule, as it is now the default and greatly improves performance.

Multiple small optimizations have been made to help slightly boost performance with this mod in general.

Bug Fixes:

Sculk Growths will no longer cause lag once you leave the spawn chunks of a server/world.

The number of threads being used will no longer double or reduce the amount of Sculk placed.

Fixed many bugs where Sculk Veins would cause log spam due to trying to change the BlockState of air.